Forbid CHECK: br and CHECK-NOT: br in codegen tests (suggest br {{.*}} instead)
#149190
+59
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v0 mangling can produce symbols with 'br' as a substring, leading to false positives for CHECK-NOT
rustbot
added
A-tidy
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
// CHECK-NOT: bris fragile to false positives in mangled symbol names, while// CHECK-NOT: br {{.*}}is not. Remove and forbid the former in codegen tests, and suggest the latter.cc #149125 (comment) where this caused a CI failure due to a v0 mangled symbol containing
brin a disambiguator/crate hash/something.